Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Side by Side Diff: chrome/browser/ui/browser_navigator_browsertest_chromeos.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_navigator_browsertest.h" 5 #include "chrome/browser/ui/browser_navigator_browsertest.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/chromeos/login/chrome_restart_request.h" 8 #include "chrome/browser/chromeos/login/chrome_restart_request.h"
9 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h" 9 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
10 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager_test.h" 10 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager_test.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest, 43 IN_PROC_BROWSER_TEST_F(BrowserGuestSessionNavigatorTest,
44 Disposition_Settings_UseIncognitoWindow) { 44 Disposition_Settings_UseIncognitoWindow) {
45 Browser* incognito_browser = CreateIncognitoBrowser(); 45 Browser* incognito_browser = CreateIncognitoBrowser();
46 46
47 EXPECT_EQ(2u, chrome::GetTotalBrowserCount()); 47 EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
48 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 48 EXPECT_EQ(1, browser()->tab_strip_model()->count());
49 EXPECT_EQ(1, incognito_browser->tab_strip_model()->count()); 49 EXPECT_EQ(1, incognito_browser->tab_strip_model()->count());
50 50
51 // Navigate to the settings page. 51 // Navigate to the settings page.
52 chrome::NavigateParams params(MakeNavigateParams(incognito_browser)); 52 chrome::NavigateParams params(MakeNavigateParams(incognito_browser));
53 params.disposition = SINGLETON_TAB; 53 params.disposition = WindowOpenDisposition::SINGLETON_TAB;
54 params.url = GURL("chrome://chrome/settings"); 54 params.url = GURL("chrome://chrome/settings");
55 params.window_action = chrome::NavigateParams::SHOW_WINDOW; 55 params.window_action = chrome::NavigateParams::SHOW_WINDOW;
56 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 56 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
57 chrome::Navigate(&params); 57 chrome::Navigate(&params);
58 58
59 // Settings page should be opened in incognito window. 59 // Settings page should be opened in incognito window.
60 EXPECT_NE(browser(), params.browser); 60 EXPECT_NE(browser(), params.browser);
61 EXPECT_EQ(incognito_browser, params.browser); 61 EXPECT_EQ(incognito_browser, params.browser);
62 EXPECT_EQ(2, incognito_browser->tab_strip_model()->count()); 62 EXPECT_EQ(2, incognito_browser->tab_strip_model()->count());
63 EXPECT_EQ(GURL("chrome://chrome/settings"), 63 EXPECT_EQ(GURL("chrome://chrome/settings"),
(...skipping 12 matching lines...) Expand all
76 { 76 {
77 const AccountId desktop_account_id( 77 const AccountId desktop_account_id(
78 AccountId::FromUserEmail("desktop_user_id@fake.com")); 78 AccountId::FromUserEmail("desktop_user_id@fake.com"));
79 TestMultiUserWindowManager* manager = 79 TestMultiUserWindowManager* manager =
80 new TestMultiUserWindowManager(browser(), desktop_account_id); 80 new TestMultiUserWindowManager(browser(), desktop_account_id);
81 81
82 EXPECT_EQ(1u, chrome::GetTotalBrowserCount()); 82 EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
83 83
84 // Navigate to the settings page. 84 // Navigate to the settings page.
85 chrome::NavigateParams params(MakeNavigateParams(browser())); 85 chrome::NavigateParams params(MakeNavigateParams(browser()));
86 params.disposition = NEW_POPUP; 86 params.disposition = WindowOpenDisposition::NEW_POPUP;
87 params.url = GURL("chrome://chrome/settings"); 87 params.url = GURL("chrome://chrome/settings");
88 params.window_action = chrome::NavigateParams::SHOW_WINDOW; 88 params.window_action = chrome::NavigateParams::SHOW_WINDOW;
89 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 89 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
90 params.browser = browser(); 90 params.browser = browser();
91 chrome::Navigate(&params); 91 chrome::Navigate(&params);
92 92
93 EXPECT_EQ(2u, chrome::GetTotalBrowserCount()); 93 EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
94 94
95 aura::Window* created_window = manager->created_window(); 95 aura::Window* created_window = manager->created_window();
96 ASSERT_TRUE(created_window); 96 ASSERT_TRUE(created_window);
97 EXPECT_TRUE( 97 EXPECT_TRUE(
98 manager->IsWindowOnDesktopOfUser(created_window, desktop_account_id)); 98 manager->IsWindowOnDesktopOfUser(created_window, desktop_account_id));
99 } 99 }
100 // Test 2: Test that a window which is not visiting does not cause an owner 100 // Test 2: Test that a window which is not visiting does not cause an owner
101 // assignment of a newly created browser. 101 // assignment of a newly created browser.
102 { 102 {
103 const AccountId browser_owner = 103 const AccountId browser_owner =
104 multi_user_util::GetAccountIdFromProfile(browser()->profile()); 104 multi_user_util::GetAccountIdFromProfile(browser()->profile());
105 TestMultiUserWindowManager* manager = 105 TestMultiUserWindowManager* manager =
106 new TestMultiUserWindowManager(browser(), browser_owner); 106 new TestMultiUserWindowManager(browser(), browser_owner);
107 107
108 // Navigate to the settings page. 108 // Navigate to the settings page.
109 chrome::NavigateParams params(MakeNavigateParams(browser())); 109 chrome::NavigateParams params(MakeNavigateParams(browser()));
110 params.disposition = NEW_POPUP; 110 params.disposition = WindowOpenDisposition::NEW_POPUP;
111 params.url = GURL("chrome://chrome/settings"); 111 params.url = GURL("chrome://chrome/settings");
112 params.window_action = chrome::NavigateParams::SHOW_WINDOW; 112 params.window_action = chrome::NavigateParams::SHOW_WINDOW;
113 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE; 113 params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
114 params.browser = browser(); 114 params.browser = browser();
115 chrome::Navigate(&params); 115 chrome::Navigate(&params);
116 116
117 EXPECT_EQ(3u, chrome::GetTotalBrowserCount()); 117 EXPECT_EQ(3u, chrome::GetTotalBrowserCount());
118 118
119 // The ShowWindowForUser should not have been called since the window is 119 // The ShowWindowForUser should not have been called since the window is
120 // already on the correct desktop. 120 // already on the correct desktop.
121 ASSERT_FALSE(manager->created_window()); 121 ASSERT_FALSE(manager->created_window());
122 } 122 }
123 } 123 }
124 124
125 } // namespace 125 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_navigator_browsertest.cc ('k') | chrome/browser/ui/browser_navigator_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698