Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4281)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index 7262dfe127c876a8acad3e50d173cacb1ab1ab10..3331731290d9588f00b9f79bd1906dd9f0f94a32 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -231,7 +231,7 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
browser->window()->Show();
// There's no current tab in this browser window, so add a new one.
- disposition = NEW_FOREGROUND_TAB;
+ disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
} else {
// For existing browser, ensure its window is shown and activated.
browser->window()->Show();
@@ -251,7 +251,7 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
params.tabstrip_add_types = add_type;
params.disposition = disposition;
- if (disposition == CURRENT_TAB) {
+ if (disposition == WindowOpenDisposition::CURRENT_TAB) {
WebContents* existing_tab =
browser->tab_strip_model()->GetActiveWebContents();
TabStripModel* model = browser->tab_strip_model();
@@ -385,7 +385,8 @@ WebContents* OpenAppShortcutWindow(Profile* profile,
const GURL& url) {
AppLaunchParams launch_params(profile,
NULL, // this is a URL app. No extension.
- extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW,
+ extensions::LAUNCH_CONTAINER_WINDOW,
+ WindowOpenDisposition::NEW_WINDOW,
extensions::SOURCE_COMMAND_LINE);
launch_params.override_url = url;
« no previous file with comments | « chrome/browser/ui/extensions/app_launch_params.cc ('k') | chrome/browser/ui/extensions/extension_installed_notification.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698