chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

index f8d9fa69ca40a5fbec0f2d4dae3e2043ba4cd8a3..9ec05b032cb3e0bfb19ab80ae370b323c9feffa5 100644

--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

@@ -90,7 +90,8 @@ void SadTabCocoa::Close() {

- (void)sadTabView:(SadTabView*)sadTabView

helpLinkClickedWithURL:(NSString*)url {

- OpenURLParams params(GURL(url.UTF8String), Referrer(), CURRENT_TAB,

+ OpenURLParams params(GURL(url.UTF8String), Referrer(),

+ WindowOpenDisposition::CURRENT_TAB,

ui::PAGE_TRANSITION_LINK, false);

webContents_->OpenURL(params);

}