Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/views/conflicting_module_view_win.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/conflicting_module_view_win.cc
diff --git a/chrome/browser/ui/views/conflicting_module_view_win.cc b/chrome/browser/ui/views/conflicting_module_view_win.cc
index 2afe6b6ec87e9aeac7c944053171bb0965853a93..e8b17977cc244f70604c9de0e9e234de6f7d0614 100644
--- a/chrome/browser/ui/views/conflicting_module_view_win.cc
+++ b/chrome/browser/ui/views/conflicting_module_view_win.cc
@@ -115,9 +115,10 @@ void ConflictingModuleView::OnWidgetClosing(views::Widget* widget) {
}
bool ConflictingModuleView::Accept() {
- browser_->OpenURL(content::OpenURLParams(
- help_center_url_, content::Referrer(), NEW_FOREGROUND_TAB,
- ui::PAGE_TRANSITION_LINK, false));
+ browser_->OpenURL(
+ content::OpenURLParams(help_center_url_, content::Referrer(),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_LINK, false));
EnumerateModulesModel::GetInstance()->AcknowledgeConflictNotification();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698