Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_observer.cc
diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc
index f7f416119759cbfd6568ab4d1b0bccca87aeaaf8..3abca97ca933f18912352a59d1d8b08d0eee3835 100644
--- a/chrome/browser/plugins/plugin_observer.cc
+++ b/chrome/browser/plugins/plugin_observer.cc
@@ -441,13 +441,14 @@ void PluginObserver::OnRemovePluginPlaceholderHost(int placeholder_id) {
#endif // defined(ENABLE_PLUGIN_INSTALLATION)
void PluginObserver::OnOpenAboutPlugins() {
- web_contents()->OpenURL(OpenURLParams(
- GURL(chrome::kChromeUIPluginsURL),
- content::Referrer::SanitizeForRequest(
- GURL(chrome::kChromeUIPluginsURL),
- content::Referrer(web_contents()->GetURL(),
- blink::WebReferrerPolicyDefault)),
- NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
+ web_contents()->OpenURL(
+ OpenURLParams(GURL(chrome::kChromeUIPluginsURL),
+ content::Referrer::SanitizeForRequest(
+ GURL(chrome::kChromeUIPluginsURL),
+ content::Referrer(web_contents()->GetURL(),
+ blink::WebReferrerPolicyDefault)),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
}
void PluginObserver::OnCouldNotLoadPlugin(const base::FilePath& plugin_path) {
« no previous file with comments | « chrome/browser/plugins/plugin_installer.cc ('k') | chrome/browser/plugins/plugin_power_saver_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698