chrome/browser/ui/pdf/pdf_unsupported_feature.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

diff --git a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

index 66220618a4a29b486aedc9c8ff4c07cddb403932..52a428e0f5466f0e4a357af2831d6ab0e095da8e 100644

--- a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

+++ b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

@@ -128,9 +128,9 @@ base::string16 PDFEnableAdobeReaderPromptClient::GetMessageText() const {

// Launch the url to get the latest Adbobe Reader installer.

void OpenReaderUpdateURL(WebContents* web_contents) {

- OpenURLParams params(

- GURL(kAdobeReaderUpdateUrl), Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false);

+ OpenURLParams params(GURL(kAdobeReaderUpdateUrl), Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

web_contents->OpenURL(params);

}