Convert WindowOpenDisposition to an enum class.

chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/test/histogram_tester.h"
 #include "base/threading/platform_thread.h"
@@ skipping 62 matching lines @@
     destroyed_watcher.Wait();
   }
 
   // Navigate to a URL in a foreground tab, move it to the background, then
   // close it. Return the upper bound for how long the URL was open in the
   // foreground.
   base::TimeDelta NavigateInForegroundAndCloseInBackgroundWithTiming(GURL url) {
     base::TimeTicks start = base::TimeTicks::Now();
     ui_test_utils::NavigateToURL(browser(), url);
     ui_test_utils::NavigateToURLWithDisposition(
-        browser(), GURL(chrome::kChromeUIVersionURL), NEW_FOREGROUND_TAB,
+        browser(), GURL(chrome::kChromeUIVersionURL),
+        WindowOpenDisposition::NEW_FOREGROUND_TAB,
         ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
     base::TimeDelta upper_bound_delta = base::TimeTicks::Now() - start;
 
     // Make sure the correct tab is in the foreground.
     TabStripModel* tab_strip_model = browser()->tab_strip_model();
     EXPECT_EQ(2, tab_strip_model->count());
     EXPECT_EQ(url, tab_strip_model->GetWebContentsAt(0)->GetURL());
     EXPECT_NE(url, tab_strip_model->GetActiveWebContents()->GetURL());
 
     content::WebContentsDestroyedWatcher destroyed_watcher(
         tab_strip_model->GetWebContentsAt(0));
     EXPECT_TRUE(tab_strip_model->CloseWebContentsAt(0, 0));
     destroyed_watcher.Wait();
     EXPECT_EQ(1, tab_strip_model->count());
 
     return upper_bound_delta;
   }
 
   // Open and close a tab without ever bringing it to the foreground.
   void NavigateInBackgroundAndClose(GURL url) {
     ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIVersionURL));
     ui_test_utils::NavigateToURLWithDisposition(
-        browser(), url, NEW_BACKGROUND_TAB,
+        browser(), url, WindowOpenDisposition::NEW_BACKGROUND_TAB,
         ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
 
     // Make sure the correct tab is in the foreground.
     TabStripModel* tab_strip_model = browser()->tab_strip_model();
     EXPECT_EQ(2, tab_strip_model->count());
     EXPECT_EQ(url, tab_strip_model->GetWebContentsAt(1)->GetURL());
     EXPECT_NE(url, tab_strip_model->GetActiveWebContents()->GetURL());
 
     content::WebContentsDestroyedWatcher destroyed_watcher(
         tab_strip_model->GetWebContentsAt(1));
     EXPECT_TRUE(tab_strip_model->CloseWebContentsAt(1, 0));
     destroyed_watcher.Wait();
     EXPECT_EQ(1, tab_strip_model->count());
   }
 
   // Open a tab in the background, then bring it to the foreground. Return the
   // upper bound for how long the URL was open in the foreground.
   base::TimeDelta NavigateInBackgroundAndCloseInForegroundWithTiming(GURL url) {
     ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIVersionURL));
     ui_test_utils::NavigateToURLWithDisposition(
-        browser(), url, NEW_BACKGROUND_TAB,
+        browser(), url, WindowOpenDisposition::NEW_BACKGROUND_TAB,
         ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
 
     // Make sure the correct tab is in the foreground.
     TabStripModel* tab_strip_model = browser()->tab_strip_model();
     EXPECT_EQ(2, tab_strip_model->count());
     EXPECT_EQ(url, tab_strip_model->GetWebContentsAt(1)->GetURL());
     EXPECT_NE(url, tab_strip_model->GetActiveWebContents()->GetURL());
 
     // Close the foreground tab.
     base::TimeTicks start = base::TimeTicks::Now();
@@ skipping 349 matching lines @@
   NavigateInForegroundAndCloseWithTiming(
       https_test_server_->GetURL("/simple.html"));
   histogram_tester_.ExpectTotalCount(
       internal::kHttpsEngagementSessionPercentage, 0);
   FakeUserMetricsUpload();
   FakeUserMetricsUpload();
   FakeUserMetricsUpload();
   histogram_tester_.ExpectTotalCount(
       internal::kHttpsEngagementSessionPercentage, 1);
 }