Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: chrome/test/ppapi/ppapi_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/ppapi/ppapi_browsertest.cc
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc
index 812e32422e8c8608d8960581dad34299fd6561a4..d01ff08eda44e8a9da2beacda2953858024ec0de 100644
--- a/chrome/test/ppapi/ppapi_browsertest.cc
+++ b/chrome/test/ppapi/ppapi_browsertest.cc
@@ -1022,7 +1022,7 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, View_CreateInvisible) {
// Make a second tab in the foreground.
GURL url = GetTestFileUrl("View_CreatedInvisible");
chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
- params.disposition = NEW_BACKGROUND_TAB;
+ params.disposition = WindowOpenDisposition::NEW_BACKGROUND_TAB;
ui_test_utils::NavigateToURL(&params);
}
@@ -1045,7 +1045,7 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, DISABLED_View_PageHideShow) {
// next phase of the test.
chrome::NavigateParams params(
browser(), GURL(url::kAboutBlankURL), ui::PAGE_TRANSITION_LINK);
- params.disposition = NEW_FOREGROUND_TAB;
+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
ui_test_utils::NavigateToURL(&params);
// Wait until the test acks that it got hidden.
@@ -1262,9 +1262,9 @@ class PackagedAppTest : public ExtensionBrowserTest {
const extensions::Extension* extension = LoadExtension(app_dir);
ASSERT_TRUE(extension);
- AppLaunchParams params(browser()->profile(), extension,
- extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,
- extensions::SOURCE_TEST);
+ AppLaunchParams params(
+ browser()->profile(), extension, extensions::LAUNCH_CONTAINER_NONE,
+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST);
params.command_line = *base::CommandLine::ForCurrentProcess();
OpenApplication(params);
}
« no previous file with comments | « chrome/test/media_router/media_router_integration_browsertest.cc ('k') | chrome/test/remoting/it2me_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698