chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/account_chooser_dialog_android.cc ('k') | chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

diff --git a/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc b/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

index 157ebc396c198ada0f262ef470eb87720aa1e889..caff964a5168c36566e4604f061a267f676b7a83 100644

--- a/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

+++ b/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc

@@ -100,8 +100,8 @@ void AutoSigninFirstRunDialogAndroid::CancelDialog(JNIEnv* env, jobject obj) {}

void AutoSigninFirstRunDialogAndroid::OnLinkClicked(JNIEnv* env, jobject obj) {

web_contents_->OpenURL(content::OpenURLParams(

GURL(password_manager::kPasswordManagerHelpCenterSmartLock),

- content::Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,

- false /* is_renderer_initiated */));

+ content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false /* is_renderer_initiated */));

}

void AutoSigninFirstRunDialogAndroid::WebContentsDestroyed() {