chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm ('k') | chrome/browser/repost_form_warning_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

index 08c940679f9e1e135e8762ba031286c5b057c133..55131068ee774bee6c14168147d234e82217ca95 100644

--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

@@ -106,7 +106,7 @@ class ChromeRenderProcessHostTest : public InProcessBrowserTest {

// renderer.

base::Process OpenBackgroundTab(const GURL& page) {

ui_test_utils::NavigateToURLWithDisposition(

- browser(), page, NEW_BACKGROUND_TAB,

+ browser(), page, WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

TabStripModel* tab_strip = browser()->tab_strip_model();

@@ -280,7 +280,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_ProcessPerTab) {

// Create another omnibox tab. It should share the process with the other

// WebUI.

ui_test_utils::NavigateToURLWithDisposition(

- browser(), omnibox, NEW_FOREGROUND_TAB,

+ browser(), omnibox, WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

tab_count++;

EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());

@@ -289,7 +289,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_ProcessPerTab) {

// Create another omnibox tab. It should share the process with the other

// WebUI.

ui_test_utils::NavigateToURLWithDisposition(

- browser(), omnibox, NEW_FOREGROUND_TAB,

+ browser(), omnibox, WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

tab_count++;

EXPECT_EQ(tab_count, browser()->tab_strip_model()->count());

@@ -514,7 +514,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest,

ui_test_utils::NavigateToURL(browser(), url);

ui_test_utils::NavigateToURLWithDisposition(

- browser(), url, NEW_BACKGROUND_TAB,

+ browser(), url, WindowOpenDisposition::NEW_BACKGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

EXPECT_EQ(2, browser()->tab_strip_model()->count());