Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 delegate_ = delegate; 245 delegate_ = delegate;
246 prompt_ = std::move(prompt); 246 prompt_ = std::move(prompt);
247 warnings_.reset([[self buildWarnings:*prompt_] retain]); 247 warnings_.reset([[self buildWarnings:*prompt_] retain]);
248 } 248 }
249 return self; 249 return self;
250 } 250 }
251 251
252 - (IBAction)storeLinkClicked:(id)sender { 252 - (IBAction)storeLinkClicked:(id)sender {
253 GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() + 253 GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +
254 prompt_->extension()->id()); 254 prompt_->extension()->id());
255 OpenURLParams params(store_url, Referrer(), NEW_FOREGROUND_TAB, 255 OpenURLParams params(store_url, Referrer(),
256 ui::PAGE_TRANSITION_LINK, false); 256 WindowOpenDisposition::NEW_FOREGROUND_TAB,
257 ui::PAGE_TRANSITION_LINK, false);
257 if (navigator_) { 258 if (navigator_) {
258 navigator_->OpenURL(params); 259 navigator_->OpenURL(params);
259 } else { 260 } else {
260 chrome::ScopedTabbedBrowserDisplayer displayer(profile_); 261 chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
261 displayer.browser()->OpenURL(params); 262 displayer.browser()->OpenURL(params);
262 } 263 }
263 264
264 delegate_->OnStoreLinkClicked(); 265 delegate_->OnStoreLinkClicked();
265 } 266 }
266 267
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 } 838 }
838 839
839 - (void)accessibilityPerformAction:(NSString*)action { 840 - (void)accessibilityPerformAction:(NSString*)action {
840 if ([action isEqualToString:NSAccessibilityPressAction]) 841 if ([action isEqualToString:NSAccessibilityPressAction])
841 [self handleLinkClicked]; 842 [self handleLinkClicked];
842 else 843 else
843 [super accessibilityPerformAction:action]; 844 [super accessibilityPerformAction:action];
844 } 845 }
845 846
846 @end 847 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698