Convert WindowOpenDisposition to an enum class.

chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
@@ skipping 25 matching lines @@
 
 PasswordManagerInternalsWebUIBrowserTest::
     PasswordManagerInternalsWebUIBrowserTest()
     : controller_(NULL) {}
 
 PasswordManagerInternalsWebUIBrowserTest::
     ~PasswordManagerInternalsWebUIBrowserTest() {}
 
 void PasswordManagerInternalsWebUIBrowserTest::SetUpOnMainThread() {
   WebUIBrowserTest::SetUpOnMainThread();
-  OpenInternalsPage(CURRENT_TAB);
+  OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB);
   AddLibrary(base::FilePath(
       FILE_PATH_LITERAL("password_manager_internals_browsertest.js")));
 }
 
 content::WebContents*
 PasswordManagerInternalsWebUIBrowserTest::GetWebContents() {
   return browser()->tab_strip_model()->GetActiveWebContents();
 }
 
 void PasswordManagerInternalsWebUIBrowserTest::OpenInternalsPage(
@@ skipping 36 matching lines @@
 }
 
 // Test that a single internals page is flushed on reload.
 IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
                        LogSavePasswordProgress_FlushedOnReload) {
   password_manager::PasswordManagerInternalsService* service =
       password_manager::PasswordManagerInternalsServiceFactory::
           GetForBrowserContext(browser()->profile());
   ASSERT_TRUE(service);
   service->ProcessLog("<script> text for testing");
-  OpenInternalsPage(CURRENT_TAB);  // Reload.
+  OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB);  // Reload.
   ASSERT_TRUE(RunJavascriptTest("testLogEmpty"));
 }
 
 // Test that if two tabs with the internals page are open, the second displays
 // the same logs. In particular, this checks that both the second tab gets the
 // logs created before the second tab was opened, and also that the second tab
 // waits with displaying until the internals page is ready (trying to display
 // the old logs just on construction time would fail).
 IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
                        LogSavePasswordProgress_MultipleTabsIdentical) {
   // First, open one tab with the internals page, and log something.
   password_manager::PasswordManagerInternalsService* service =
       password_manager::PasswordManagerInternalsServiceFactory::
           GetForBrowserContext(browser()->profile());
   ASSERT_TRUE(service);
   service->ProcessLog("<script> text for testing");
   ASSERT_TRUE(RunJavascriptTest("testLogText"));
   // Now open a second tab with the internals page, but do not log anything.
-  OpenInternalsPage(NEW_FOREGROUND_TAB);
+  OpenInternalsPage(WindowOpenDisposition::NEW_FOREGROUND_TAB);
   // The previously logged text should have made it to the page.
   ASSERT_TRUE(RunJavascriptTest("testLogText"));
 }
 
 // Test that in the presence of more internals pages, reload does not cause
 // flushing the logs.
 IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
                        LogSavePasswordProgress_NotFlushedOnReloadIfMultiple) {
   // Open one more tab with the internals page.
-  OpenInternalsPage(NEW_FOREGROUND_TAB);
+  OpenInternalsPage(WindowOpenDisposition::NEW_FOREGROUND_TAB);
   // Now log something.
   password_manager::PasswordManagerInternalsService* service =
       password_manager::PasswordManagerInternalsServiceFactory::
           GetForBrowserContext(browser()->profile());
   ASSERT_TRUE(service);
   service->ProcessLog("<script> text for testing");
   // Reload.
-  OpenInternalsPage(CURRENT_TAB);
+  OpenInternalsPage(WindowOpenDisposition::CURRENT_TAB);
   // The text should still be there.
   ASSERT_TRUE(RunJavascriptTest("testLogText"));
 }
 
 // Test that navigation away from the internals page works OK.
 IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
                        LogSavePasswordProgress_NavigateAway) {
   password_manager::PasswordManagerInternalsService* service =
       password_manager::PasswordManagerInternalsServiceFactory::
           GetForBrowserContext(browser()->profile());
@@ skipping 13 matching lines @@
 }
 
 // Test that the description is correct in an Incognito tab.
 IN_PROC_BROWSER_TEST_F(PasswordManagerInternalsWebUIBrowserTest,
                        IncognitoMessage) {
   Browser* incognito = CreateIncognitoBrowser();
   password_manager::PasswordManagerInternalsService* service =
       password_manager::PasswordManagerInternalsServiceFactory::
           GetForBrowserContext(incognito->profile()->GetOffTheRecordProfile());
   EXPECT_FALSE(service);  // There should be no service for Incognito.
-  OpenInternalsPageWithBrowser(incognito, CURRENT_TAB);
+  OpenInternalsPageWithBrowser(incognito, WindowOpenDisposition::CURRENT_TAB);
   SetWebUIInstance(
       incognito->tab_strip_model()->GetActiveWebContents()->GetWebUI());
   ASSERT_TRUE(RunJavascriptTest("testIncognitoDescription"));
 }