Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: chrome/browser/ui/extensions/app_launch_params.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/app_launch_params.cc
diff --git a/chrome/browser/ui/extensions/app_launch_params.cc b/chrome/browser/ui/extensions/app_launch_params.cc
index 46ad14254963f0c8511ed0649f6e04cf9744ec90..7306b9da4c852c4f5c59c18d4ade472cb2736597 100644
--- a/chrome/browser/ui/extensions/app_launch_params.cc
+++ b/chrome/browser/ui/extensions/app_launch_params.cc
@@ -71,11 +71,11 @@ AppLaunchParams CreateAppLaunchParamsWithEventFlags(
extensions::LaunchContainer container;
WindowOpenDisposition disposition;
- if (raw_disposition == NEW_FOREGROUND_TAB ||
- raw_disposition == NEW_BACKGROUND_TAB) {
+ if (raw_disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB ||
+ raw_disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB) {
container = extensions::LAUNCH_CONTAINER_TAB;
disposition = raw_disposition;
- } else if (raw_disposition == NEW_WINDOW) {
+ } else if (raw_disposition == WindowOpenDisposition::NEW_WINDOW) {
container = extensions::LAUNCH_CONTAINER_WINDOW;
disposition = raw_disposition;
} else {
@@ -83,7 +83,7 @@ AppLaunchParams CreateAppLaunchParamsWithEventFlags(
// is set, launch as a regular tab.
container =
extensions::GetLaunchContainer(ExtensionPrefs::Get(profile), extension);
- disposition = NEW_FOREGROUND_TAB;
+ disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
}
return AppLaunchParams(profile, extension, container, disposition, source);
}
« no previous file with comments | « chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698