chrome/browser/ui/views/session_crashed_bubble_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/session_crashed_bubble_view.cc

diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.cc b/chrome/browser/ui/views/session_crashed_bubble_view.cc

index f45bebb9a12ea36ca4967dfd6af2c2ce2854e8a1..eb8caabab90955a24ee71c88a7575c73bf9c4f46 100644

--- a/chrome/browser/ui/views/session_crashed_bubble_view.cc

+++ b/chrome/browser/ui/views/session_crashed_bubble_view.cc

@@ -360,10 +360,8 @@ void SessionCrashedBubbleView::StyledLabelLinkClicked(views::StyledLabel* label,

int event_flags) {

browser_->OpenURL(content::OpenURLParams(

GURL("https://support.google.com/chrome/answer/96817"),

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK,

- false));

+ content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false));

RecordBubbleHistogramValue(SESSION_CRASHED_BUBBLE_HELP);

}