chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

index cd2d58a6019ee7f7380c96eb9abb5513678d71b0..6d2bf4cc94df828fa07ad7cc783610c919704ef9 100644

--- a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

@@ -407,11 +407,9 @@ void KeyboardOverlayHandler::GetLabelMap(const base::ListValue* args) {

void KeyboardOverlayHandler::OpenLearnMorePage(const base::ListValue* args) {

web_ui()->GetWebContents()->GetDelegate()->OpenURLFromTab(

web_ui()->GetWebContents(),

- content::OpenURLParams(GURL(kLearnMoreURL),

- content::Referrer(),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK,

- false));

+ content::OpenURLParams(GURL(kLearnMoreURL), content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false));

}

////////////////////////////////////////////////////////////////////////////////