chrome/browser/media/defer_background_media_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/defer_background_media_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/defer_background_media_browsertest.cc

diff --git a/chrome/browser/media/defer_background_media_browsertest.cc b/chrome/browser/media/defer_background_media_browsertest.cc

index d30178c649a5745c8126cc0a1b0b387953496c8e..e6b4dd1a9ce4dc3161016f04c62033f82a3e30a5 100644

--- a/chrome/browser/media/defer_background_media_browsertest.cc

+++ b/chrome/browser/media/defer_background_media_browsertest.cc

@@ -29,7 +29,8 @@ IN_PROC_BROWSER_TEST_F(DeferredMediaBrowserTest, BackgroundMediaIsDeferred) {

ui_test_utils::NavigateToURLWithDisposition(

browser(), content::GetFileUrlWithQuery(

media::GetTestDataFilePath("bear-640x360.webm"), ""),

- NEW_BACKGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

+ WindowOpenDisposition::NEW_BACKGROUND_TAB,

+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

ASSERT_EQ(2, browser()->tab_strip_model()->count());

content::WebContents* background_contents =