Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/ntp_snippets/content_suggestions_metrics.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc ('k') | components/omnibox/browser/omnibox_edit_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/content_suggestions_metrics.cc
diff --git a/components/ntp_snippets/content_suggestions_metrics.cc b/components/ntp_snippets/content_suggestions_metrics.cc
index 614ce7567439fd182c10a890d9a95ea5f5401958..5d4fbe169ad5a462da482bcc432b02bbbaa3b785 100644
--- a/components/ntp_snippets/content_suggestions_metrics.cc
+++ b/components/ntp_snippets/content_suggestions_metrics.cc
@@ -181,11 +181,12 @@ void OnSuggestionOpened(int global_position,
LogCategoryHistogramScore(kHistogramOpenedScore, category, score);
- UMA_HISTOGRAM_ENUMERATION(kHistogramOpenDisposition, disposition,
- WINDOW_OPEN_DISPOSITION_LAST + 1);
- LogCategoryHistogramEnumeration(kHistogramOpenDisposition, category,
- disposition,
- WINDOW_OPEN_DISPOSITION_LAST + 1);
+ UMA_HISTOGRAM_ENUMERATION(
+ kHistogramOpenDisposition, static_cast<int>(disposition),
+ static_cast<int>(WindowOpenDisposition::MAX_VALUE) + 1);
+ LogCategoryHistogramEnumeration(
+ kHistogramOpenDisposition, category, static_cast<int>(disposition),
+ static_cast<int>(WindowOpenDisposition::MAX_VALUE) + 1);
}
void OnSuggestionMenuOpened(int global_position,
« no previous file with comments | « components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc ('k') | components/omnibox/browser/omnibox_edit_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698