Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
(...skipping 1499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1510 // Currently, Textfield (which covers the omnibox and find bar, and likely any 1510 // Currently, Textfield (which covers the omnibox and find bar, and likely any
1511 // other native UI in the future that wants to deal with clipboard commands) 1511 // other native UI in the future that wants to deal with clipboard commands)
1512 // does the above. 1512 // does the above.
1513 ui::Accelerator accelerator; 1513 ui::Accelerator accelerator;
1514 GetAccelerator(command_id, &accelerator); 1514 GetAccelerator(command_id, &accelerator);
1515 GetFocusManager()->ProcessAccelerator(accelerator); 1515 GetFocusManager()->ProcessAccelerator(accelerator);
1516 } 1516 }
1517 1517
1518 WindowOpenDisposition BrowserView::GetDispositionForPopupBounds( 1518 WindowOpenDisposition BrowserView::GetDispositionForPopupBounds(
1519 const gfx::Rect& bounds) { 1519 const gfx::Rect& bounds) {
1520 return NEW_POPUP; 1520 return WindowOpenDisposition::NEW_POPUP;
1521 } 1521 }
1522 1522
1523 FindBar* BrowserView::CreateFindBar() { 1523 FindBar* BrowserView::CreateFindBar() {
1524 return new FindBarHost(this); 1524 return new FindBarHost(this);
1525 } 1525 }
1526 1526
1527 WebContentsModalDialogHost* BrowserView::GetWebContentsModalDialogHost() { 1527 WebContentsModalDialogHost* BrowserView::GetWebContentsModalDialogHost() {
1528 return GetBrowserViewLayout()->GetWebContentsModalDialogHost(); 1528 return GetBrowserViewLayout()->GetWebContentsModalDialogHost();
1529 } 1529 }
1530 1530
(...skipping 1134 matching lines...) Expand 10 before | Expand all | Expand 10 after
2665 } 2665 }
2666 2666
2667 extensions::ActiveTabPermissionGranter* 2667 extensions::ActiveTabPermissionGranter*
2668 BrowserView::GetActiveTabPermissionGranter() { 2668 BrowserView::GetActiveTabPermissionGranter() {
2669 content::WebContents* web_contents = GetActiveWebContents(); 2669 content::WebContents* web_contents = GetActiveWebContents();
2670 if (!web_contents) 2670 if (!web_contents)
2671 return nullptr; 2671 return nullptr;
2672 return extensions::TabHelper::FromWebContents(web_contents) 2672 return extensions::TabHelper::FromWebContents(web_contents)
2673 ->active_tab_permission_granter(); 2673 ->active_tab_permission_granter();
2674 } 2674 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698