Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/test/remoting/remote_desktop_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/remoting/remote_desktop_browsertest.cc
diff --git a/chrome/test/remoting/remote_desktop_browsertest.cc b/chrome/test/remoting/remote_desktop_browsertest.cc
index c0609a6541fd0bb826123018c3c7d8e4deac88e9..46021ee2292388022cccb4f6997a454380a56376 100644
--- a/chrome/test/remoting/remote_desktop_browsertest.cc
+++ b/chrome/test/remoting/remote_desktop_browsertest.cc
@@ -77,9 +77,9 @@ void RemoteDesktopBrowserTest::VerifyInternetAccess() {
void RemoteDesktopBrowserTest::OpenClientBrowserPage() {
// Open the client browser page in a new tab
ui_test_utils::NavigateToURLWithDisposition(
- browser(),
- GURL(http_server() + "/client.html"),
- NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
+ browser(), GURL(http_server() + "/client.html"),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
// Save this web content for later reference
client_web_content_ = browser()->tab_strip_model()->GetActiveWebContents();
@@ -195,7 +195,7 @@ content::WebContents* RemoteDesktopBrowserTest::LaunchChromotingApp(
defer_start);
if (is_platform_app()) {
- window_open_disposition = NEW_WINDOW;
+ window_open_disposition = WindowOpenDisposition::NEW_WINDOW;
}
OpenApplication(AppLaunchParams(browser()->profile(), extension_,
@@ -237,7 +237,7 @@ content::WebContents* RemoteDesktopBrowserTest::LaunchChromotingApp(
content::WebContents* RemoteDesktopBrowserTest::LaunchChromotingApp(
bool defer_start) {
- return LaunchChromotingApp(defer_start, CURRENT_TAB);
+ return LaunchChromotingApp(defer_start, WindowOpenDisposition::CURRENT_TAB);
}
void RemoteDesktopBrowserTest::StartChromotingApp() {

Powered by Google App Engine
This is Rietveld 408576698