Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: chrome/browser/ui/browser_navigator_params.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator_params.cc
diff --git a/chrome/browser/ui/browser_navigator_params.cc b/chrome/browser/ui/browser_navigator_params.cc
index d60cc75e0fb06c754c7337bfb659d10ca9ad51e2..40ddeaacd6dc11bb149c888b252db941d168fb77 100644
--- a/chrome/browser/ui/browser_navigator_params.cc
+++ b/chrome/browser/ui/browser_navigator_params.cc
@@ -25,7 +25,7 @@ NavigateParams::NavigateParams(WebContents* a_target_contents)
uses_post(false),
target_contents(a_target_contents),
source_contents(nullptr),
- disposition(CURRENT_TAB),
+ disposition(WindowOpenDisposition::CURRENT_TAB),
trusted_source(false),
transition(ui::PAGE_TRANSITION_LINK),
is_renderer_initiated(false),
@@ -37,8 +37,7 @@ NavigateParams::NavigateParams(WebContents* a_target_contents)
ref_behavior(IGNORE_REF),
initiating_profile(nullptr),
should_replace_current_entry(false),
- created_with_opener(false) {
-}
+ created_with_opener(false) {}
#else
NavigateParams::NavigateParams(Browser* a_browser,
const GURL& a_url,
@@ -48,7 +47,7 @@ NavigateParams::NavigateParams(Browser* a_browser,
uses_post(false),
target_contents(NULL),
source_contents(NULL),
- disposition(CURRENT_TAB),
+ disposition(WindowOpenDisposition::CURRENT_TAB),
trusted_source(false),
transition(a_transition),
is_renderer_initiated(false),
@@ -61,8 +60,7 @@ NavigateParams::NavigateParams(Browser* a_browser,
browser(a_browser),
initiating_profile(NULL),
should_replace_current_entry(false),
- created_with_opener(false) {
-}
+ created_with_opener(false) {}
NavigateParams::NavigateParams(Browser* a_browser,
WebContents* a_target_contents)
@@ -70,7 +68,7 @@ NavigateParams::NavigateParams(Browser* a_browser,
uses_post(false),
target_contents(a_target_contents),
source_contents(NULL),
- disposition(CURRENT_TAB),
+ disposition(WindowOpenDisposition::CURRENT_TAB),
trusted_source(false),
transition(ui::PAGE_TRANSITION_LINK),
is_renderer_initiated(false),
@@ -83,8 +81,7 @@ NavigateParams::NavigateParams(Browser* a_browser,
browser(a_browser),
initiating_profile(NULL),
should_replace_current_entry(false),
- created_with_opener(false) {
-}
+ created_with_opener(false) {}
#endif // !defined(OS_ANDROID)
NavigateParams::NavigateParams(Profile* a_profile,
@@ -95,7 +92,7 @@ NavigateParams::NavigateParams(Profile* a_profile,
uses_post(false),
target_contents(NULL),
source_contents(NULL),
- disposition(NEW_FOREGROUND_TAB),
+ disposition(WindowOpenDisposition::NEW_FOREGROUND_TAB),
trusted_source(false),
transition(a_transition),
is_renderer_initiated(false),
« no previous file with comments | « chrome/browser/ui/browser_navigator_browsertest_chromeos.cc ('k') | chrome/browser/ui/browser_tabrestore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698