chrome/browser/extensions/extension_context_menu_model.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_context_menu_model.cc

diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc

index 2755e9d0bc945a9431d6059f01aede87a66be1f2..773a28b5e6169d3cf04064407bc0a6723d89018d 100644

--- a/chrome/browser/extensions/extension_context_menu_model.cc

+++ b/chrome/browser/extensions/extension_context_menu_model.cc

@@ -244,7 +244,8 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id,

switch (command_id) {

case NAME: {

content::OpenURLParams params(ManifestURL::GetHomepageURL(extension),

- content::Referrer(), NEW_FOREGROUND_TAB,

+ content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui::PAGE_TRANSITION_LINK, false);

browser_->OpenURL(params);

break;