chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/session_crashed_bubble_view.cc ('k') | chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

index 6273577561c1664b2885f1c313dd1059a074132c..c8308cff197b0c9e827298d612e17829e63e0ce1 100644

--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

@@ -235,7 +235,7 @@ void ProfileSigninConfirmationDialogViews::StyledLabelLinkClicked(

browser_,

GURL("https://support.google.com/chromebook/answer/1331549"),

ui::PAGE_TRANSITION_LINK);

- params.disposition = NEW_POPUP;

+ params.disposition = WindowOpenDisposition::NEW_POPUP;

params.window_action = chrome::NavigateParams::SHOW_WINDOW;

chrome::Navigate(&params);

}