chrome/browser/chromeos/extensions/input_method_api.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/input_method_api.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/input_method_api.cc

diff --git a/chrome/browser/chromeos/extensions/input_method_api.cc b/chrome/browser/chromeos/extensions/input_method_api.cc

index 7c947e106e87aa6a2d1b1e048a5a13c83acd366f..54ba091521ca9d32eb65c835332621e5efbd32ae 100644

--- a/chrome/browser/chromeos/extensions/input_method_api.cc

+++ b/chrome/browser/chromeos/extensions/input_method_api.cc

@@ -289,8 +289,8 @@ InputMethodPrivateOpenOptionsPageFunction::Run() {

if (!options_page_url.is_empty()) {

Browser* browser = chrome::FindBrowserWithWebContents(web_contents);

content::OpenURLParams url_params(options_page_url, content::Referrer(),

- SINGLETON_TAB, ui::PAGE_TRANSITION_LINK,

- false);

+ WindowOpenDisposition::SINGLETON_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

browser->OpenURL(url_params);

}