chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

index 1f9582a0159ab4099749705d5868b0c85df149c6..ac2d4803f174f30e5feeb6b0e487e6cb480acf75 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm

@@ -99,7 +99,8 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, ShowInUninitializedTab) {

content::WebContents::CreateParams(browser()->profile())));

bool was_blocked = false;

chrome::AddWebContents(browser(), NULL, web_contents.release(),

- NEW_BACKGROUND_TAB, gfx::Rect(), false, &was_blocked);

+ WindowOpenDisposition::NEW_BACKGROUND_TAB, gfx::Rect(),

+ false, &was_blocked);

content::WebContents* tab2 =

browser()->tab_strip_model()->GetWebContentsAt(2);

ASSERT_TRUE(tab2);