chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 1d2228c85fcbe1d371a121b62352b0ca4b4474ba..ecbada62435369634490c4dd20f5b37231b9a1e8 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -752,8 +752,8 @@ WindowOpenDisposition BrowserWindowCocoa::GetDispositionForPopupBounds(

const gfx::Rect& bounds) {

// When using Cocoa's System Fullscreen mode, convert popups into tabs.

if ([controller_ isInAppKitFullscreen])

- return NEW_FOREGROUND_TAB;

- return NEW_POPUP;

+ return WindowOpenDisposition::NEW_FOREGROUND_TAB;

+ return WindowOpenDisposition::NEW_POPUP;

}

FindBar* BrowserWindowCocoa::CreateFindBar() {