Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/base/window_open_disposition.h

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/cocoa/cocoa_base_utils_unittest.mm ('k') | ui/base/window_open_disposition.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/window_open_disposition.h
diff --git a/ui/base/window_open_disposition.h b/ui/base/window_open_disposition.h
index 74fcfbe11401a8dea4de6c4bf1bb9f37323fea4f..f6dc4fb982128bfe6a8a22996c5c0b003f74e7aa 100644
--- a/ui/base/window_open_disposition.h
+++ b/ui/base/window_open_disposition.h
@@ -9,7 +9,7 @@
// A Java counterpart will be generated for this enum.
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.ui
-enum WindowOpenDisposition {
+enum class WindowOpenDisposition {
UNKNOWN,
CURRENT_TAB,
// Indicates that only one tab with the url should exist in the same window.
@@ -22,7 +22,7 @@ enum WindowOpenDisposition {
OFF_THE_RECORD,
IGNORE_ACTION,
// Update when adding a new disposition.
- WINDOW_OPEN_DISPOSITION_LAST = IGNORE_ACTION
+ MAX_VALUE = IGNORE_ACTION
};
namespace ui {
« no previous file with comments | « ui/base/cocoa/cocoa_base_utils_unittest.mm ('k') | ui/base/window_open_disposition.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698