chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm ('k') | chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

index 279270e89e1449f0bd2ad32dde72bd66d1b3bdb3..1d5ca184df0cc370b3e855119171c2100d107b20 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

@@ -252,8 +252,9 @@ bool HasAttribute(id item, CellAttributesMask attributeMask) {

- (IBAction)storeLinkClicked:(id)sender {

GURL store_url(extension_urls::GetWebstoreItemDetailURLPrefix() +

prompt_->extension()->id());

- OpenURLParams params(store_url, Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false);

+ OpenURLParams params(store_url, Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

if (navigator_) {

navigator_->OpenURL(params);

} else {