Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ui/base/window_open_disposition.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/window_open_disposition.h ('k') | ui/keyboard/content/keyboard_ui_content.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/window_open_disposition.cc
diff --git a/ui/base/window_open_disposition.cc b/ui/base/window_open_disposition.cc
index c0d131f4bfc4035d4e30b5be76282f69186cbc1f..90d9fbd4ca4b08ed92c2892486d15bdc696b5f5e 100644
--- a/ui/base/window_open_disposition.cc
+++ b/ui/base/window_open_disposition.cc
@@ -20,12 +20,13 @@ WindowOpenDisposition DispositionFromClick(bool middle_button,
#else
if (middle_button || ctrl_key)
#endif
- return shift_key ? NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB;
+ return shift_key ? WindowOpenDisposition::NEW_FOREGROUND_TAB
+ : WindowOpenDisposition::NEW_BACKGROUND_TAB;
if (shift_key)
- return NEW_WINDOW;
+ return WindowOpenDisposition::NEW_WINDOW;
if (alt_key)
- return SAVE_TO_DISK;
- return CURRENT_TAB;
+ return WindowOpenDisposition::SAVE_TO_DISK;
+ return WindowOpenDisposition::CURRENT_TAB;
}
WindowOpenDisposition DispositionFromEventFlags(int event_flags) {
« no previous file with comments | « ui/base/window_open_disposition.h ('k') | ui/keyboard/content/keyboard_ui_content.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698