chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/instant_extended_interactive_uitest.cc ('k') | chrome/browser/ui/search/instant_search_prerenderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc

diff --git a/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc

index df4ec7f9a74320a4320265f413a0f3fbc033dc52..578cac2a9c32636dbff0a5f8d3312afc2407c73a 100644

--- a/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc

+++ b/chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc

@@ -100,10 +100,8 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedManualTest, MANUAL_SearchesFromFakebox) {

content::NOTIFICATION_NAV_ENTRY_COMMITTED,

content::NotificationService::AllSources());

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- GURL(chrome::kChromeUINewTabURL),

- CURRENT_TAB,

- ui_test_utils::BROWSER_TEST_NONE);

+ browser(), GURL(chrome::kChromeUINewTabURL),

+ WindowOpenDisposition::CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);

observer.Wait();

content::WebContents* active_tab =

browser()->tab_strip_model()->GetActiveWebContents();