chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/applescript/window_applescript.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

index 6c49dca17469d331bc682d01733cf0c18e741be6..875522440ca51263c632ac3fae1fdec7ceb1cef1 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

@@ -66,9 +66,9 @@ class NativeAppWindowCocoaBrowserTest

content::WindowedNotificationObserver app_loaded_observer(

content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

content::NotificationService::AllSources());

- OpenApplication(

- AppLaunchParams(profile(), app_, extensions::LAUNCH_CONTAINER_NONE,

- NEW_WINDOW, extensions::SOURCE_TEST));

+ OpenApplication(AppLaunchParams(

+ profile(), app_, extensions::LAUNCH_CONTAINER_NONE,

+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_TEST));

app_loaded_observer.Wait();

}