Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/android/service_tab_launcher.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/service_tab_launcher.cc
diff --git a/chrome/browser/android/service_tab_launcher.cc b/chrome/browser/android/service_tab_launcher.cc
index 02ae62c9c7de56f74abbc1f5cd0dfb0e8e6900d7..92a8a1a2b9bf88fa570dd0c22f04714a6c702eea 100644
--- a/chrome/browser/android/service_tab_launcher.cc
+++ b/chrome/browser/android/service_tab_launcher.cc
@@ -43,8 +43,10 @@ void ServiceTabLauncher::LaunchTab(content::BrowserContext* browser_context,
const content::OpenURLParams& params,
const TabLaunchedCallback& callback) {
WindowOpenDisposition disposition = params.disposition;
- if (disposition != NEW_WINDOW && disposition != NEW_POPUP &&
- disposition != NEW_FOREGROUND_TAB && disposition != NEW_BACKGROUND_TAB) {
+ if (disposition != WindowOpenDisposition::NEW_WINDOW &&
+ disposition != WindowOpenDisposition::NEW_POPUP &&
+ disposition != WindowOpenDisposition::NEW_FOREGROUND_TAB &&
+ disposition != WindowOpenDisposition::NEW_BACKGROUND_TAB) {
// ServiceTabLauncher can currently only launch new tabs.
NOTIMPLEMENTED();
return;
@@ -66,7 +68,7 @@ void ServiceTabLauncher::LaunchTab(content::BrowserContext* browser_context,
Java_ServiceTabLauncher_launchTab(env, GetApplicationContext(), request_id,
browser_context->IsOffTheRecord(), url,
- disposition, referrer_url,
+ static_cast<int>(disposition), referrer_url,
params.referrer.policy, headers, post_data);
}
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698