chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm

index 147a7981c860f5ea1af50673f457dd5a8d7b457e..fd8c94f676d75acdc29bbfc6fe37ebe3b7b41b3c 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm

@@ -65,10 +65,9 @@ NSString* kBookmarkButtonDragType = @"com.google.chrome.BookmarkButtonDrag";

NSEvent* event = [NSApp currentEvent];

WindowOpenDisposition disposition =

ui::WindowOpenDispositionFromNSEvent(event);

- if (([event type] != NSMouseEntered) &&

- ([event type] != NSMouseMoved) &&

+ if (([event type] != NSMouseEntered) && ([event type] != NSMouseMoved) &&

([event type] != NSScrollWheel) &&

- (disposition == NEW_BACKGROUND_TAB)) {

+ (disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB)) {

[controller_ closeAllBookmarkFolders];

[controller_ openAll:[sender bookmarkNode] disposition:disposition];

return;