chrome/browser/ui/views/web_dialog_view_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/web_dialog_view_browsertest.cc b/chrome/browser/ui/views/web_dialog_view_browsertest.cc

index 3c5be53b5c25fd0e81b52a67e00baec7829765db..4d987b0f837f3ec5f1a91316befc41b628cc7a2b 100644

--- a/chrome/browser/ui/views/web_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/web_dialog_view_browsertest.cc

@@ -222,7 +222,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) {

IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, CloseParentWindow) {

// Open a second browser window so we don't trigger shutdown.

ui_test_utils::NavigateToURLWithDisposition(

- browser(), GURL(url::kAboutBlankURL), NEW_WINDOW,

+ browser(), GURL(url::kAboutBlankURL), WindowOpenDisposition::NEW_WINDOW,

ui_test_utils::BROWSER_TEST_NONE);

// TestWebDialogDelegate defaults to window-modal, so closing the browser