Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6535)

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
index 8127a3e2dca329153286f0270f9776ba7c8688f5..17140ef75f3c5fa918f8306228311855451075af 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
@@ -143,12 +143,9 @@ void AppListControllerDelegate::ShowAppInWebStore(
is_search_result ?
AppListControllerDelegate::LAUNCH_FROM_APP_LIST_SEARCH :
AppListControllerDelegate::LAUNCH_FROM_APP_LIST);
- OpenURL(profile,
- net::AppendQueryParameter(url,
- extension_urls::kWebstoreSourceField,
- source),
- ui::PAGE_TRANSITION_LINK,
- CURRENT_TAB);
+ OpenURL(profile, net::AppendQueryParameter(
+ url, extension_urls::kWebstoreSourceField, source),
+ ui::PAGE_TRANSITION_LINK, WindowOpenDisposition::CURRENT_TAB);
}
bool AppListControllerDelegate::HasOptionsPage(
@@ -166,10 +163,8 @@ void AppListControllerDelegate::ShowOptionsPage(
if (!extension)
return;
- OpenURL(profile,
- extensions::OptionsPageInfo::GetOptionsPage(extension),
- ui::PAGE_TRANSITION_LINK,
- CURRENT_TAB);
+ OpenURL(profile, extensions::OptionsPageInfo::GetOptionsPage(extension),
+ ui::PAGE_TRANSITION_LINK, WindowOpenDisposition::CURRENT_TAB);
}
extensions::LaunchType AppListControllerDelegate::GetExtensionLaunchType(

Powered by Google App Engine
This is Rietveld 408576698