Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4891)

Unified Diff: chrome/browser/ui/browser_tabstrip.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_tabrestore_browsertest.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_tabstrip.cc
diff --git a/chrome/browser/ui/browser_tabstrip.cc b/chrome/browser/ui/browser_tabstrip.cc
index 995e0de1a4ecf609711db7b6108d8a513a4722cf..f75af143dbfc1f2f9756b0eb8fcc9da02db36dfe 100644
--- a/chrome/browser/ui/browser_tabstrip.cc
+++ b/chrome/browser/ui/browser_tabstrip.cc
@@ -27,7 +27,8 @@ void AddTabAt(Browser* browser, const GURL& url, int idx, bool foreground) {
chrome::NavigateParams params(browser,
url.is_empty() ? GURL(chrome::kChromeUINewTabURL) : url,
ui::PAGE_TRANSITION_TYPED);
- params.disposition = foreground ? NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB;
+ params.disposition = foreground ? WindowOpenDisposition::NEW_FOREGROUND_TAB
+ : WindowOpenDisposition::NEW_BACKGROUND_TAB;
params.tabstrip_index = idx;
chrome::Navigate(&params);
CoreTabHelper* core_tab_helper =
@@ -40,7 +41,7 @@ content::WebContents* AddSelectedTabWithURL(
const GURL& url,
ui::PageTransition transition) {
NavigateParams params(browser, url, transition);
- params.disposition = NEW_FOREGROUND_TAB;
+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
Navigate(&params);
return params.target_contents;
}
@@ -53,9 +54,9 @@ void AddWebContents(Browser* browser,
bool user_gesture,
bool* was_blocked) {
// No code for this yet.
- DCHECK(disposition != SAVE_TO_DISK);
+ DCHECK(disposition != WindowOpenDisposition::SAVE_TO_DISK);
// Can't create a new contents for the current tab - invalid case.
- DCHECK(disposition != CURRENT_TAB);
+ DCHECK(disposition != WindowOpenDisposition::CURRENT_TAB);
NavigateParams params(browser, new_contents);
params.source_contents = source_contents;
« no previous file with comments | « chrome/browser/ui/browser_tabrestore_browsertest.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698