ios/web/navigation/navigation_manager_impl.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/navigation_manager_impl.mm

diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm

index 89df52f90dc130d0fe7917bf2cd796fe46145f58..8a7effd46d68d9c445a0bf4238d53d31e316627e 100644

--- a/ios/web/navigation/navigation_manager_impl.mm

+++ b/ios/web/navigation/navigation_manager_impl.mm

@@ -168,7 +168,8 @@ CRWSessionController* NavigationManagerImpl::GetSessionController() {

void NavigationManagerImpl::LoadURL(const GURL& url,

const web::Referrer& referrer,

ui::PageTransition type) {

- WebState::OpenURLParams params(url, referrer, CURRENT_TAB, type, NO);

+ WebState::OpenURLParams params(url, referrer,

+ WindowOpenDisposition::CURRENT_TAB, type, NO);

delegate_->GetWebState()->OpenURL(params);

}

@@ -310,7 +311,8 @@ void NavigationManagerImpl::Reload(bool check_for_reposts) {

GURL url = item ? item->GetURL() : GURL(url::kAboutBlankURL);

web::Referrer referrer = item ? item->GetReferrer() : web::Referrer();

- WebState::OpenURLParams params(url, referrer, CURRENT_TAB,

+ WebState::OpenURLParams params(url, referrer,

+ WindowOpenDisposition::CURRENT_TAB,

ui::PAGE_TRANSITION_RELOAD, NO);

delegate_->GetWebState()->OpenURL(params);

}