chrome/browser/search/hotword_service.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/hotword_service.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/hotword_service.cc

diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc

index 2e60e060a1c912a6f72ae20503388216b65cf6c1..45c7ce086203888dc7ea0935449df99b6fb9e9ce 100644

--- a/chrome/browser/search/hotword_service.cc

+++ b/chrome/browser/search/hotword_service.cc

@@ -710,9 +710,9 @@ void HotwordService::LaunchHotwordAudioVerificationApp(

if (!extension)

return;

- OpenApplication(

- AppLaunchParams(profile_, extension, extensions::LAUNCH_CONTAINER_WINDOW,

- NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));

+ OpenApplication(AppLaunchParams(

+ profile_, extension, extensions::LAUNCH_CONTAINER_WINDOW,

+ WindowOpenDisposition::NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));

}

HotwordService::LaunchMode