content/browser/web_contents/web_drag_dest_mac.mm - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_drag_dest_mac.mm

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_drag_dest_mac.mm

diff --git a/content/browser/web_contents/web_drag_dest_mac.mm b/content/browser/web_contents/web_drag_dest_mac.mm

index d549b5489378856bbc2dc084778a14702358babc..9e595764594f79b978df8e5a44564fa30939c9e2 100644

--- a/content/browser/web_contents/web_drag_dest_mac.mm

+++ b/content/browser/web_contents/web_drag_dest_mac.mm

@@ -235,9 +235,9 @@ int GetModifierFlags() {

if ([pboard containsURLDataConvertingTextToURL:YES]) {

GURL url;

ui::PopulateURLAndTitleFromPasteboard(&url, NULL, pboard, YES);

- webContents_->OpenURL(OpenURLParams(

- url, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_AUTO_BOOKMARK,

- false));

+ webContents_->OpenURL(

+ OpenURLParams(url, Referrer(), WindowOpenDisposition::CURRENT_TAB,

+ ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

return YES;

} else {

return NO;