chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index b9569827d04569d3f82a29328125ee34c386b0fd..286acd912b8b5195e211f9be5c5da109c944230a 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -454,9 +454,8 @@ class SafeBrowsingBlockingPageBrowserTest

// Trigger the safe browsing interstitial page via a redirect in

// "openWin()".

ui_test_utils::NavigateToURLWithDisposition(

- browser(),

- GURL("javascript:" + open_function + "()"),

- CURRENT_TAB,

+ browser(), GURL("javascript:" + open_function + "()"),

+ WindowOpenDisposition::CURRENT_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);

WebContents* contents =

browser()->tab_strip_model()->GetActiveWebContents();