chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

index 7f1d2f45e9c350f332e56c6bb8477953854d2ab3..45bbfa29489ef462af1f32a0c15d9fed4050218e 100644

--- a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

+++ b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

@@ -120,11 +120,9 @@ IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, CloseSelf) {

}

IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Navigate) {

- content::OpenURLParams params(GURL("about:blank"),

- content::Referrer(),

- CURRENT_TAB,

- ui::PAGE_TRANSITION_LINK,

- false);

+ content::OpenURLParams params(GURL("about:blank"), content::Referrer(),

+ WindowOpenDisposition::CURRENT_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

browser()->tab_strip_model()->GetActiveWebContents()->OpenURL(params);

EXPECT_EQ(0, accepted_count_);