blimp/engine/session/blimp_engine_session.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/session/blimp_engine_session.cc

diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc

index 9029e8de941b580274a98a9b0c5eed7ad3f75b5a..d0c4759ed7d945cb54dd8ed798ff55b61431f6c8 100644

--- a/blimp/engine/session/blimp_engine_session.cc

+++ b/blimp/engine/session/blimp_engine_session.cc

@@ -515,7 +515,7 @@ content::WebContents* BlimpEngineSession::OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) {

// CURRENT_TAB is the only one we implement for now.

- if (params.disposition != CURRENT_TAB) {

+ if (params.disposition != WindowOpenDisposition::CURRENT_TAB) {

NOTIMPLEMENTED();

return nullptr;

}