Issue 7064033: Virtual destructors should have virtual keyword.

Issue 7064033: Virtual destructors should have virtual keyword. (Closed)

Created:
9 years, 7 months ago by hans

Modified:
9 years, 5 months ago

Reviewers:
darin (slow to review), Nico, Elliot Glaysher

CC:
chromium-reviews, vrk (LEFT CHROMIUM), dmaclach+watch_chromium.org, annacc, stuartmorgan+watch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, dhollowa, cbentzel+watch_chromium.org, Jói, idana, Erik does not do reviews, jam, apatrick_chromium, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), jamiewalch+watch_chromium.org, Avi (use Gerrit), ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, ncarter (slow), Randy Smith (Not in Mondays), simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), michaeln, hclam+watch_chromium.org, sjl, tfarina, garykac+watch_chromium.org, Aaron Boodman, acolwell GONE FROM CHROMIUM, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Virtual destructors should have virtual keyword. Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86587

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+331 lines, -324 lines)			Patch
M	base/message_loop.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_pump_default.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/synchronization/waitable_event_watcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/task_queue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/values.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_contents_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background_application_list_model.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_html_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_storage.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browsing_data_remover.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_policy_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/browser_list_tabcontents_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/devtools_netlog_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/debugger/inspectable_tab_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/save_package.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_apitest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browser_actions_api.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_api.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_debugger_api.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_event_router.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_history_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_i18n_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_infobar_module.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_management_api.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.h	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View	4 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_test_api.h	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_test_message_listener.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_toolbar_model.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tts_api.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/user_script_listener.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/file_select_helper.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_notifications.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_types.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/in_memory_history_backend.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/top_sites_backend.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/icon_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/importer_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/instant/instant_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/intranet_redirect_detector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/mach_broker_mac.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/chrome_net_log.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/load_timing_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/net_log_logger.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/net/net_pref_observer.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/net/passive_log_collector.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/url_request_failed_dns_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_mock_link_doctor_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_mock_net_error_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_request_slow_http_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/omnibox_search_hint.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_data_remover.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_data_remover_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/profile_policy_connector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_dialog_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_worker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/off_the_record_profile_io_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_io_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/download_resource_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/safe_browsing_resource_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/search_engines/search_provider_install_state_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/spellcheck_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/all_status.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/generic_change_processor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/http_bridge.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_system_resources.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/util/extensions_activity_monitor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/thumbnail_generator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tabs/tab_finder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/translate/translate_tab_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/transport_security_persister.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/constrained_window_mac.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/balloon_view_bridge.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/theme_install_bubble_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/custom_button.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_item_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/download/download_shelf_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/reload_button_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/status_icons/status_tray_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tab_contents_container_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tab_contents_drag_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history2_ui.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/keyboard_ui.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_login_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/shared_resources_data_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_database_table.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
A	chrome/browser/webdata/web_database_table.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/net/test_url_fetcher_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/nacl/nacl_launcher_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_histogram_snapshots.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/malware_dom_details.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/searchbox.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/gaia/service_gaia_authenticator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/service_process.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/live_sync/live_autofill_sync_test.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/live_sync/live_bookmarks_sync_test.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/render_view_test.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/test_notification_tracker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/appcache/appcache_dispatcher_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/cert_store.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/file_system/file_system_dispatcher_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/core_location_provider_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/geolocation_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/location_arbitrator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/mock_location_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/gpu/gpu_process_host_ui_shim.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/host_zoom_map.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/in_process_webkit/dom_storage_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/mime_registry_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/mock_resource_context.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/plugin_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/blob_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/browser_render_process_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/clipboard_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/file_utilities_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/quota_dispatcher_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/sync_resource_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/resolve_proxy_msg_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/worker_host/worker_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/worker_host/worker_process_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/file_system/file_system_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/font_config_ipc_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/gpu/gpu_channel_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/quota_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/resource_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/gpu/gpu_child_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/gpu/gpu_process.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/npobject_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/npobject_stub.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/plugin_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/webplugin_delegate_stub.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/webplugin_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/ppapi_plugin/ppapi_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/audio_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/gpu_channel_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/indexed_db_dispatcher.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/plugin_channel_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_process_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/renderer_webidbobjectstore_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/webplugin_delegate_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/webworker_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/worker/worker_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel_posix.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_message_macros.h	View	5 chunks	+4 lines, -5 lines	0 comments	Download
M	ipc/ipc_sync_channel.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_test_sink.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/xmpp_connection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/filters.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/cert_verifier.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/cookie_monster.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/dnsrr_resolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/mock_host_resolver.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/ssl_client_auth_cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/backend_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/file_lock.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/disk_cache/file_lock.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/mem_entry_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/stats_histogram.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_network_layer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_auth_handler_basic.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_auth_handler_digest.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_auth_handler_ntlm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_stream_parser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/client_socket_pool_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/client_socket_pool_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/socket_test_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/ssl_client_socket_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/ssl_client_socket_nss.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/tcp_server_socket_libevent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket_stream/socket_stream.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/tools/flip_server/acceptor_thread.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/tools/flip_server/simple_buffer.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	net/tools/flip_server/simple_buffer.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	net/tools/flip_server/sm_connection.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	net/tools/flip_server/sm_connection.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	net/url_request/https_prober.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_data_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_error_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_simple_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_cairo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/client/plugin/pepper_xmpp_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/capturer_fake.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/capturer_fake_ascii.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/iq_request.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/ssl_socket_adapter.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/jingle_session_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/protocol/rtp_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/vector_platform_device_skia.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_disk_cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_update_job.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/appcache/view_appcache_internals_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/blob/view_blob_internals_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/weburlloader_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/test/plugin_thread_async_call_test.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/webplugin_delegate_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/quota/usage_tracker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/support/simple_database_system.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_request_context.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Rubberstampy LGTM. Can you add "No functionality change: virtual is only added to destructors that ...

9 years, 7 months ago (2011-05-24 18:26:02 UTC) #2

rubber stamp LGTM

Expand Messages | Collapse Messages