Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: ipc/ipc_message_macros.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_posix.h ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_macros.h
diff --git a/ipc/ipc_message_macros.h b/ipc/ipc_message_macros.h
index 87e9c208aaf7191a3a94c71f5ed9b57e21ce6d4d..34b510359f2d5931d22cfbf2809b313846fe3e67 100644
--- a/ipc/ipc_message_macros.h
+++ b/ipc/ipc_message_macros.h
@@ -442,7 +442,7 @@
public: \
enum { ID = IPC_MESSAGE_ID() }; \
msg_class(IPC_TYPE_IN_##in_cnt in_list); \
- ~msg_class(); \
+ virtual ~msg_class(); \
static void Log(std::string* name, const Message* msg, std::string* l); \
};
@@ -453,7 +453,7 @@
enum { ID = IPC_MESSAGE_ID() }; \
msg_class(int32 routing_id IPC_COMMA_##in_cnt \
IPC_TYPE_IN_##in_cnt in_list); \
- ~msg_class(); \
+ virtual ~msg_class(); \
static void Log(std::string* name, const Message* msg, std::string* l); \
};
@@ -466,7 +466,7 @@
msg_class(IPC_TYPE_IN_##in_cnt in_list \
IPC_COMMA_AND_##in_cnt(IPC_COMMA_##out_cnt) \
IPC_TYPE_OUT_##out_cnt out_list); \
- ~msg_class(); \
+ virtual ~msg_class(); \
static void Log(std::string* name, const Message* msg, std::string* l); \
};
@@ -481,7 +481,7 @@
IPC_TYPE_IN_##in_cnt in_list \
IPC_COMMA_AND_##in_cnt(IPC_COMMA_##out_cnt) \
IPC_TYPE_OUT_##out_cnt out_list); \
- ~msg_class(); \
+ virtual ~msg_class(); \
static void Log(std::string* name, const Message* msg, std::string* l); \
};
@@ -777,4 +777,3 @@ LogFunctionMap g_log_function_mapping;
// XXX_messages.h files need not do so themselves. This makes the
// XXX_messages.h files easier to write.
#undef IPC_MESSAGE_START
-
« no previous file with comments | « ipc/ipc_channel_posix.h ('k') | ipc/ipc_sync_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698