Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: webkit/appcache/appcache_update_job.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_host.h ('k') | webkit/appcache/view_appcache_internals_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_update_job.h
diff --git a/webkit/appcache/appcache_update_job.h b/webkit/appcache/appcache_update_job.h
index 04c3c80154b159849bdb5ad695b12f68aa12be8b..b85d73ba13f4b76a1974e22c4390960c09da5a35 100644
--- a/webkit/appcache/appcache_update_job.h
+++ b/webkit/appcache/appcache_update_job.h
@@ -33,7 +33,7 @@ class AppCacheUpdateJob : public AppCacheStorage::Delegate,
public AppCacheHost::Observer {
public:
AppCacheUpdateJob(AppCacheService* service, AppCacheGroup* group);
- ~AppCacheUpdateJob();
+ virtual ~AppCacheUpdateJob();
// Triggers the update process or adds more info if this update is already
// in progress.
@@ -101,7 +101,7 @@ class AppCacheUpdateJob : public AppCacheStorage::Delegate,
URLFetcher(const GURL& url,
FetchType fetch_type,
AppCacheUpdateJob* job);
- ~URLFetcher();
+ virtual ~URLFetcher();
void Start();
FetchType fetch_type() const { return fetch_type_; }
net::URLRequest* request() const { return request_.get(); }
« no previous file with comments | « webkit/appcache/appcache_host.h ('k') | webkit/appcache/view_appcache_internals_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698