Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: content/plugin/webplugin_proxy.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/plugin/webplugin_delegate_stub.h ('k') | content/ppapi_plugin/ppapi_thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_ 5 #ifndef CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_
6 #define CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_ 6 #define CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 30 matching lines...) Expand all
41 // renderer. 41 // renderer.
42 class WebPluginProxy : public webkit::npapi::WebPlugin { 42 class WebPluginProxy : public webkit::npapi::WebPlugin {
43 public: 43 public:
44 // Creates a new proxy for WebPlugin, using the given sender to send the 44 // Creates a new proxy for WebPlugin, using the given sender to send the
45 // marshalled WebPlugin calls. 45 // marshalled WebPlugin calls.
46 WebPluginProxy(PluginChannel* channel, 46 WebPluginProxy(PluginChannel* channel,
47 int route_id, 47 int route_id,
48 const GURL& page_url, 48 const GURL& page_url,
49 gfx::NativeViewId containing_window, 49 gfx::NativeViewId containing_window,
50 int host_render_view_routing_id); 50 int host_render_view_routing_id);
51 ~WebPluginProxy(); 51 virtual ~WebPluginProxy();
52 52
53 void set_delegate(webkit::npapi::WebPluginDelegateImpl* d) { delegate_ = d; } 53 void set_delegate(webkit::npapi::WebPluginDelegateImpl* d) { delegate_ = d; }
54 54
55 // WebPlugin overrides 55 // WebPlugin overrides
56 virtual void SetWindow(gfx::PluginWindowHandle window); 56 virtual void SetWindow(gfx::PluginWindowHandle window);
57 57
58 // Whether input events should be sent to the delegate. 58 // Whether input events should be sent to the delegate.
59 virtual void SetAcceptsInputEvents(bool accepts); 59 virtual void SetAcceptsInputEvents(bool accepts);
60 60
61 virtual void WillDestroyWindow(gfx::PluginWindowHandle window); 61 virtual void WillDestroyWindow(gfx::PluginWindowHandle window);
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 216
217 #endif 217 #endif
218 218
219 // Contains the routing id of the host render view. 219 // Contains the routing id of the host render view.
220 int host_render_view_routing_id_; 220 int host_render_view_routing_id_;
221 221
222 ScopedRunnableMethodFactory<WebPluginProxy> runnable_method_factory_; 222 ScopedRunnableMethodFactory<WebPluginProxy> runnable_method_factory_;
223 }; 223 };
224 224
225 #endif // CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_ 225 #endif // CONTENT_PLUGIN_WEBPLUGIN_PROXY_H_
OLDNEW
« no previous file with comments | « content/plugin/webplugin_delegate_stub.h ('k') | content/ppapi_plugin/ppapi_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698