Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: net/base/mock_host_resolver.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/dnsrr_resolver.h ('k') | net/base/ssl_client_auth_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mock_host_resolver.h
diff --git a/net/base/mock_host_resolver.h b/net/base/mock_host_resolver.h
index 44667f4d5459ff946fc742cd3e74200434dc6789..b9e2f2836d55c63c39e6a1d2df88bd1590b3330d 100644
--- a/net/base/mock_host_resolver.h
+++ b/net/base/mock_host_resolver.h
@@ -95,7 +95,7 @@ class MockHostResolver : public MockHostResolverBase {
class MockCachingHostResolver : public MockHostResolverBase {
public:
MockCachingHostResolver() : MockHostResolverBase(true /*use_caching*/) {}
- ~MockCachingHostResolver() {}
+ virtual ~MockCachingHostResolver() {}
};
// RuleBasedHostResolverProc applies a set of rules to map a host string to
@@ -147,7 +147,7 @@ class NET_TEST RuleBasedHostResolverProc : public HostResolverProc {
struct Rule;
typedef std::list<Rule> RuleList;
- ~RuleBasedHostResolverProc();
+ virtual ~RuleBasedHostResolverProc();
RuleList rules_;
};
« no previous file with comments | « net/base/dnsrr_resolver.h ('k') | net/base/ssl_client_auth_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698