Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Unified Diff: chrome/browser/sync/glue/http_bridge.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/http_bridge.h
diff --git a/chrome/browser/sync/glue/http_bridge.h b/chrome/browser/sync/glue/http_bridge.h
index 4c013925560373ea6d15fedc722be384c2c85e34..a4ee3eb5082b34ae127641b4967f561b89c6851d 100644
--- a/chrome/browser/sync/glue/http_bridge.h
+++ b/chrome/browser/sync/glue/http_bridge.h
@@ -61,7 +61,7 @@ class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,
private:
// The destructor MUST be called on the IO thread.
- ~RequestContext();
+ virtual ~RequestContext();
std::string user_agent_;
net::URLRequestContext* baseline_context_;
@@ -83,7 +83,7 @@ class HttpBridge : public base::RefCountedThreadSafe<HttpBridge>,
virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const;
private:
- ~RequestContextGetter() {}
+ virtual ~RequestContextGetter() {}
// User agent to apply to the net::URLRequestContext.
std::string user_agent_;
« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.h ('k') | chrome/browser/sync/notifier/chrome_system_resources.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698