net/tools/flip_server/simple_buffer.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/flip_server/simple_buffer.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/flip_server/simple_buffer.h

diff --git a/net/tools/flip_server/simple_buffer.h b/net/tools/flip_server/simple_buffer.h

index fee7d4b104ec7a11d75dcff26b080a16d760f979..831531dd4a48863a9f4ce3f59fb281c14012d812 100644

--- a/net/tools/flip_server/simple_buffer.h

+++ b/net/tools/flip_server/simple_buffer.h

@@ -16,9 +16,7 @@ class SimpleBuffer : public BufferInterface {

public:

SimpleBuffer();

explicit SimpleBuffer(int size);

- virtual ~SimpleBuffer() {

- delete[] storage_;

- }

+ virtual ~SimpleBuffer();

std::string str() const;

@@ -92,4 +90,3 @@ class SimpleBuffer : public BufferInterface {

} // namespace net

#endif // NET_TOOLS_FLIP_SERVER_SIMPLE_BUFFER_H__

« no previous file with comments | « net/tools/flip_server/acceptor_thread.h ('k') | net/tools/flip_server/simple_buffer.cc » ('j') | no next file with comments »