Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: net/base/dnsrr_resolver.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/cookie_monster.h ('k') | net/base/mock_host_resolver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_DNSRR_RESOLVER_H_ 5 #ifndef NET_BASE_DNSRR_RESOLVER_H_
6 #define NET_BASE_DNSRR_RESOLVER_H_ 6 #define NET_BASE_DNSRR_RESOLVER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 kInvalidHandle = 0, 76 kInvalidHandle = 0,
77 }; 77 };
78 78
79 enum { 79 enum {
80 // Try harder to get a DNSSEC signed response. This doesn't mean that the 80 // Try harder to get a DNSSEC signed response. This doesn't mean that the
81 // RRResponse will always have the dnssec bit set. 81 // RRResponse will always have the dnssec bit set.
82 FLAG_WANT_DNSSEC = 1, 82 FLAG_WANT_DNSSEC = 1,
83 }; 83 };
84 84
85 DnsRRResolver(); 85 DnsRRResolver();
86 ~DnsRRResolver(); 86 virtual ~DnsRRResolver();
87 87
88 uint64 requests() const { return requests_; } 88 uint64 requests() const { return requests_; }
89 uint64 cache_hits() const { return cache_hits_; } 89 uint64 cache_hits() const { return cache_hits_; }
90 uint64 inflight_joins() const { return inflight_joins_; } 90 uint64 inflight_joins() const { return inflight_joins_; }
91 91
92 // Resolve starts the resolution process. When complete, |callback| is called 92 // Resolve starts the resolution process. When complete, |callback| is called
93 // with a result. If the result is |OK| then |response| is filled with the 93 // with a result. If the result is |OK| then |response| is filled with the
94 // result of the resolution. Note that |callback| is called via the current 94 // result of the resolution. Note that |callback| is called via the current
95 // MessageLoop. 95 // MessageLoop.
96 // 96 //
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 uint64 inflight_joins_; 128 uint64 inflight_joins_;
129 129
130 bool in_destructor_; 130 bool in_destructor_;
131 131
132 DISALLOW_COPY_AND_ASSIGN(DnsRRResolver); 132 DISALLOW_COPY_AND_ASSIGN(DnsRRResolver);
133 }; 133 };
134 134
135 } // namespace net 135 } // namespace net
136 136
137 #endif // NET_BASE_DNSRR_RESOLVER_H_ 137 #endif // NET_BASE_DNSRR_RESOLVER_H_
OLDNEW
« no previous file with comments | « net/base/cookie_monster.h ('k') | net/base/mock_host_resolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698