Virtual destructors should have virtual keyword.

webkit/appcache/appcache_update_job.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_UPDATE_JOB_H_
 #define WEBKIT_APPCACHE_APPCACHE_UPDATE_JOB_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 15 matching lines @@
 
 namespace appcache {
 
 class HostNotifier;
 
 // Application cache Update algorithm and state.
 class AppCacheUpdateJob : public AppCacheStorage::Delegate,
                           public AppCacheHost::Observer {
  public:
   AppCacheUpdateJob(AppCacheService* service, AppCacheGroup* group);
-  ~AppCacheUpdateJob();
+  virtual ~AppCacheUpdateJob();
 
   // Triggers the update process or adds more info if this update is already
   // in progress.
   void StartUpdate(AppCacheHost* host, const GURL& new_master_resource);
 
  private:
   friend class ScopedRunnableMethodFactory<AppCacheUpdateJob>;
   friend class AppCacheUpdateJobTest;
   class URLFetcher;
 
@@ skipping 47 matching lines @@
    public:
     enum FetchType {
       MANIFEST_FETCH,
       URL_FETCH,
       MASTER_ENTRY_FETCH,
       MANIFEST_REFETCH,
     };
     URLFetcher(const GURL& url,
                FetchType fetch_type,
                AppCacheUpdateJob* job);
-    ~URLFetcher();
+    virtual ~URLFetcher();
     void Start();
     FetchType fetch_type() const { return fetch_type_; }
     net::URLRequest* request() const { return request_.get(); }
     const AppCacheEntry& existing_entry() const { return existing_entry_; }
     const std::string& manifest_data() const { return manifest_data_; }
     AppCacheResponseWriter* response_writer() const {
       return response_writer_.get();
     }
     void set_existing_response_headers(net::HttpResponseHeaders* headers) {
       existing_response_headers_ = headers;
@@ skipping 199 matching lines @@
       policy_callback_;
 
   FRIEND_TEST_ALL_PREFIXES(AppCacheGroupTest, QueueUpdate);
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheUpdateJob);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_UPDATE_JOB_H_